Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track the time before processing a request #183

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Track the time before processing a request #183

merged 3 commits into from
Jun 22, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Jun 22, 2023 •
edited
Loading

in particular load() and setupConnection()

Also track how many slow requests we see

Track the time before processing a request
cc8e6d9 
in particular load() and setupConnection()
@DMRobertson
Copy link
Contributor Author

Setup duration seems to work:

# HELP sliding_sync_api_setup_duration_secs Time taken in seconds after receiving a request before we start calculating a sliding sync response.
# TYPE sliding_sync_api_setup_duration_secs histogram
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="0.005"} 55
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="0.01"} 55
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="0.025"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="0.05"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="0.1"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="0.25"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="0.5"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="1"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="2.5"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="5"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="10"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="0",le="+Inf"} 56
sliding_sync_api_setup_duration_secs_sum{initial="0"} 0.067084623
sliding_sync_api_setup_duration_secs_count{initial="0"} 56
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="0.005"} 0
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="0.01"} 0
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="0.025"} 0
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="0.05"} 0
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="0.1"} 0
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="0.25"} 5
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="0.5"} 19
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="1"} 19
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="2.5"} 19
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="5"} 19
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="10"} 19
sliding_sync_api_setup_duration_secs_bucket{initial="1",le="+Inf"} 19
sliding_sync_api_setup_duration_secs_sum{initial="1"} 5.910332403
sliding_sync_api_setup_duration_secs_count{initial="1"} 19

@DMRobertson
Copy link
Contributor Author 

# HELP sliding_sync_api_slow_requests Counter of slow (>=50s) requests, initial or otherwise.
# TYPE sliding_sync_api_slow_requests counter
sliding_sync_api_slow_requests 45

sanity checked this by forcing the threshold to be > 0 instead of > 50

@DMRobertson DMRobertson merged commit bdcffda into dmr/debug-from-stable Jun 22, 2023
4 checks passed
@DMRobertson DMRobertson deleted the dmr/setup-metrics branch July 12, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DMRobertson